Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jsrsasign: init at 10.8.6 #267026

Closed
wants to merge 1 commit into from
Closed

jsrsasign: init at 10.8.6 #267026

wants to merge 1 commit into from

Conversation

Jappie3
Copy link
Contributor

@Jappie3 Jappie3 commented Nov 12, 2023

Description of changes

Adds the NPM package jsrsasign to nodePackages.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Nov 12, 2023
@linsui
Copy link
Contributor

linsui commented Nov 12, 2023 •
edited
Loading

See #229475

@ofborg ofborg bot requested a review from Luflosi November 12, 2023 11:22
@Jappie3
Copy link
Contributor Author

Jappie3 commented Nov 12, 2023

The problem with packaging jsrsasign using buildNpmPackage is that there does not seem to be a package-lock.json file in the Github repo (https://github.com/kjur/jsrsasign). If you have any ideas or suggestions on how I could possibly package this, I'd love to hear them @linsui

@linsui
Copy link
Contributor

linsui commented Nov 12, 2023

It seems it has no deps so you don't even need buildNpmPackage.

@Jappie3
Copy link
Contributor Author

Jappie3 commented Nov 12, 2023

I'll look into it & close this for now, thanks ^^

@Jappie3 Jappie3 closed this Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luflosi Luflosi Awaiting requested review from Luflosi

Assignees
No one assigned
Labels
6.topic: nodejs 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jappie3 @linsui @NixOSInfra